Skip to content

[improve][broker] PIP-192: Filter the transfer dest broker#19958

Merged
Technoboy- merged 3 commits into
apache:masterfrom
Demogorgon314:Demogorgon314/PIP-192-filter-dest-broker
Apr 5, 2023
Merged

[improve][broker] PIP-192: Filter the transfer dest broker#19958
Technoboy- merged 3 commits into
apache:masterfrom
Demogorgon314:Demogorgon314/PIP-192-filter-dest-broker

Conversation

@Demogorgon314

@Demogorgon314 Demogorgon314 commented Mar 29, 2023

Copy link
Copy Markdown
Member

Master Issue: #16691

Motivation

The PIP-192 introduced transfer to transfer the bundle from ower broker to a specific broker without unloading,
But the dest broker is not filtered by the broker filter.

Modifications

  • Filter out the dest broker by broker filter.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Demogorgon314 Demogorgon314 self-assigned this Mar 29, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Mar 29, 2023
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/PIP-192-filter-dest-broker branch from 9f2a551 to abee92c Compare March 30, 2023 08:45
@Demogorgon314 Demogorgon314 marked this pull request as ready for review March 30, 2023 13:13
@Demogorgon314 Demogorgon314 added ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Mar 31, 2023
@codecov-commenter

codecov-commenter commented Mar 31, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.80%. Comparing base (68c10ee) to head (aaa8711).
⚠️ Report is 2684 commits behind head on master.

Files with missing lines Patch % Lines
...dbalance/extensions/scheduler/TransferShedder.java 86.20% 0 Missing and 4 partials ⚠️
...nsions/policies/AntiAffinityGroupPolicyHelper.java 0.00% 2 Missing ⚠️
...tensions/filter/BrokerIsolationPoliciesFilter.java 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19958      +/-   ##
============================================
- Coverage     72.89%   72.80%   -0.10%     
+ Complexity    31619    31576      -43     
============================================
  Files          1861     1861              
  Lines        137356   137353       -3     
  Branches      15117    15115       -2     
============================================
- Hits         100131   100000     -131     
- Misses        29271    29385     +114     
- Partials       7954     7968      +14
Flag Coverage Δ
inttests 24.28% <0.00%> (-0.15%) ⬇️
systests 25.12% <0.00%> (+0.08%) ⬆️
unittests 72.09% <82.50%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dbalance/extensions/ExtensibleLoadManagerImpl.java 76.21% <100.00%> (+0.14%) ⬆️
...tensions/filter/AntiAffinityGroupPolicyFilter.java 83.33% <ø> (+11.90%) ⬆️
...e/extensions/filter/BrokerMaxTopicCountFilter.java 87.50% <ø> (-1.39%) ⬇️
...balance/extensions/filter/BrokerVersionFilter.java 80.39% <ø> (-0.38%) ⬇️
...e/extensions/policies/IsolationPoliciesHelper.java 87.50% <100.00%> (+0.83%) ⬆️
...tensions/filter/BrokerIsolationPoliciesFilter.java 88.88% <66.66%> (ø)
...nsions/policies/AntiAffinityGroupPolicyHelper.java 77.27% <0.00%> (-13.36%) ⬇️
...dbalance/extensions/scheduler/TransferShedder.java 83.07% <86.20%> (+1.64%) ⬆️

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Demogorgon314

Demogorgon314 commented Apr 4, 2023

Copy link
Copy Markdown
Member Author

@gaoran10 @Technoboy- PTAL by any chance.

@heesung-sohn heesung-sohn mentioned this pull request Apr 4, 2023
Closed
@Technoboy- Technoboy- added this to the 3.0.0 milestone Apr 5, 2023
@Technoboy- Technoboy- merged commit 7813dab into apache:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@heesung-sohn heesung-sohn heesung-sohn approved these changes

@gaoran10 gaoran10 Awaiting requested review from gaoran10

Assignees

@Demogorgon314 Demogorgon314

Labels

area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Demogorgon314 @codecov-commenter @Technoboy- @heesung-sohn