[improve][broker][PIP-195] Merge multiple buckets at once#19927
Merged
Conversation
bee2dba to
9162451
Compare
9162451 to
4109066
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19927 +/- ##
============================================
+ Coverage 61.50% 61.95% +0.44%
- Complexity 25755 26070 +315
============================================
Files 1859 1859
Lines 136792 136796 +4
Branches 15043 15042 -1
============================================
+ Hits 84129 84747 +618
+ Misses 44857 44247 -610
+ Partials 7806 7802 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mattisonchao
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIP: #16763
Motivation
Currently, we select two buckets at once to merge, which causes the merge operation to be frequently triggered. We should merge multiple buckets at once to avoid frequent merges.
Modifications
CombinedSegmentDelayedIndexQueueVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: