[improve][test] Migrate tests to use PulsarTestContext#19376
Merged
Conversation
4 tasks
…ntSynchronizer in tests
…nsumerSharedSubscription - add some debug logging and some comments about the issue
c52801a to
05bc4ab
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
michaeljmarshall
approved these changes
Feb 1, 2023
michaeljmarshall
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the detailed Javadocs @lhotari! I left some comments that should probably be addressed. I am approving the PR since the comments are very minor.
- SameThreadOrderedSafeExecutor is simply a single threaded OrderedExecutor
- this makes it less instrusive
This was referenced Jul 4, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR continues changes made in previous PRs (#19337, #19326, #19323) to refactor Pulsar unit tests to reduce mocking which causes flakiness since Mockito isn't thread safe.
One key motivation for this PR is to extend PulsarTestContext features so that most tests can be migrated to use it to reduce the use of Mockito spies in the way that causes flakiness. Mockito Spies aren't completely removed, but it moves to a better direction.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#139