[fix][broker] Allow user lookup topic name with -partition- but no metadata
#19171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
reviewed
Jan 10, 2023
...ar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #19171 +/- ##
============================================
+ Coverage 45.64% 47.42% +1.78%
+ Complexity 11043 10779 -264
============================================
Files 773 713 -60
Lines 74463 69730 -4733
Branches 8018 7496 -522
============================================
- Hits 33986 33072 -914
+ Misses 36687 32933 -3754
+ Partials 3790 3725 -65
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
reviewed
Jan 12, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jan 12, 2023
mattisonchao
commented
Jan 12, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Outdated
Show resolved
Hide resolved
…/NamespaceService.java
eolivelli
approved these changes
Jan 12, 2023
| .create(); | ||
| producer.close(); | ||
| // Check the topic exist in the list again. | ||
| Assert.assertTrue(topics.contains(partition2)); |
Contributor
There was a problem hiding this comment.
we didn't call topics = admin.topics().getList("prop/ns-abc"); again.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This behaviour is broken by PR #18193,
In the previous version, we could use the pulsar client to look up the topic with the
-partition-keyword. Even this topic doesn't have partition metadata. But currently, we can't do that. You can check the test to know the detail.Modifications
-partition-but no metadataVerifying this change
Documentation
doc-not-needed