[fix][broker] Reject create non-existent persistent partitions#19086
Merged
Conversation
poorbarcode
approved these changes
Dec 28, 2022
liangyepianzhou
left a comment
Contributor
There was a problem hiding this comment.
Maybe we should change this to
return metadata.orElseGet(() -> new PartitionedTopicMetadata(-1));
eolivelli
reviewed
Dec 28, 2022
congbobo184
reviewed
Dec 28, 2022
Contributor
There was a problem hiding this comment.
without this change, the test also can pass @mattisonchao
this line has already guaranteed can't create partition-4 topic.
Codecov Report
@@ Coverage Diff @@
## master #19086 +/- ##
============================================
- Coverage 47.46% 46.27% -1.19%
+ Complexity 10727 9318 -1409
============================================
Files 711 633 -78
Lines 69456 59871 -9585
Branches 7452 6238 -1214
============================================
- Hits 32964 27706 -5258
+ Misses 32810 29111 -3699
+ Partials 3682 3054 -628
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
@congbobo184 Aha, sorry. I need to change the topic name to |
congbobo184
approved these changes
Dec 28, 2022
coderzc
approved these changes
Dec 30, 2022
Member
Author
|
I use the workaround method to fix the restful endpoint @eolivelli @codelipenghui @liangyepianzhou Could you review it again? |
liangyepianzhou
approved these changes
Jan 8, 2023
eolivelli
requested changes
Jan 9, 2023
Technoboy-
approved these changes
Jan 9, 2023
3 tasks
Denovo1998
reviewed
Sep 7, 2023
| if (topicName.isPartitioned()) { | ||
| return fetchPartitionedTopicMetadataAsync(TopicName.get(topicName.getPartitionedTopicName())) | ||
| .thenCompose((metadata) -> { | ||
| // Allow crate non-partitioned persistent topic that name includes `partition` |
Contributor
There was a problem hiding this comment.
@mattisonchao There's a spelling problem here. crate -> create
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19085
Master Issue: #19085
Motivation
See #19085
ML: https://lists.apache.org/thread/3s7b7dh0h9qcnn8x3lclxmw75okkqf37
Modifications
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete