[improve] [broker] filter system topics while shedding#18936
Conversation
congbobo184
left a comment
There was a problem hiding this comment.
A system topic can be unloaded, allowing it to be load balanced. If you filter the system topic, it may lead to uneven resource allocation.
In the master branch, topics/bundles in and actually we can achieve distributing bundles containing In our production clusters, we use
|
I think this logic was introduced by mistake by pr #15252
I will see the PIP later. and I think the |
Should i raise a PR to revert mistake in the master branch?
I think that load balancing strategy such as |
yes, I think we need a pr to revert this change
I think we need to find out why the Tc recover so slowly, Is it a logic error, or need to expand the TC? if it is a logic error, we need to fix. later I will think about how to optimize the recovery time of TC |
|
The pr had no activity for 30 days, mark with Stale label. |



Fixes #18935
Motivation
Topics/Bundles will be unload while doing shedding, and there are some special topics that should not be unloaded for some reason. For example, if
transaction_coordinator_assignis unloaded, the corresponding TC need to be recovered, which is time consuming.So, we have better avoid unload these topics. And i found that such features have been implemented in the latest branch except branch-2.9.
Modifications
fitler system topics while shedding in branch-2.9.
Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: thetumbled#9