[WebSocket] Add configuration metadata store url setting in websocket #13786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation As per apache#13077, `configurationStoreServers` need to be renamed to `configurationMetadataStoreUrl`. Modification * Add `configurationMetadataStoreUrl` setting to websocket * Deprecate `configurationStoreServers` in websocket Signed-off-by: Zike Yang <zkyang@streamnative.io>
...websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java
Show resolved
Hide resolved
Member
|
Hi @RobertIndie I've removed BTW, #13758 can be merged after this PR gets merged? |
Signed-off-by: Zike Yang <zkyang@streamnative.io>
Member
Author
Thanks.
Yes. #13758 already contains the doc for this PR. |
Member
Author
|
/pulsarbot run-failure-checks |
nodece
reviewed
Jan 21, 2022
...websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #13760
Motivation
As per #13077,
configurationStoreServersneed to be renamed toconfigurationMetadataStoreUrl.Modifications
configurationMetadataStoreUrlsetting to websocketconfigurationStoreServersin websocketVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
doc-required#13758 contains doc changes for this PR.