Use SecurityUtility class #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
commented
Feb 10, 2018
| // allows insecure connection | ||
| builder.trustManager(InsecureTrustManagerFactory.INSTANCE); | ||
| SslContext sslCtx = builder.clientAuth(ClientAuth.OPTIONAL).build(); | ||
| SslContext sslCtx = SecurityUtility.createNettySslContextForClient(true, |
Member
Author
There was a problem hiding this comment.
Note that the first argument forallowInsecureConnection is true because the original code always allows insecure connection regardless of configuration. If it wasn't intentional, it need to be fixed.
Contributor
There was a problem hiding this comment.
can we also add comment SecurityUtility.createNettySslContextForClient(true\* to allow InsecureConnection*\,..)
Member
Author
|
I know |
rdhabalia
reviewed
Feb 10, 2018
| // allows insecure connection | ||
| builder.trustManager(InsecureTrustManagerFactory.INSTANCE); | ||
| SslContext sslCtx = builder.clientAuth(ClientAuth.OPTIONAL).build(); | ||
| SslContext sslCtx = SecurityUtility.createNettySslContextForClient(true, |
Contributor
There was a problem hiding this comment.
can we also add comment SecurityUtility.createNettySslContextForClient(true\* to allow InsecureConnection*\,..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
createNettySslContexttocreateNettySslContextForClientcreateNettySslContextForServercreateNettySslContextForServerfromPulsarChannelInitializerandServiceChannelInitializerResult