Skip to content

Fix compilation failure in master branch #10250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aahmed-se merged 1 commit into from
Apr 17, 2021
Merged

Fix compilation failure in master branch #10250

aahmed-se merged 1 commit into from
Apr 17, 2021

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Apr 17, 2021

Motivation

Compiling master branch fails with errors in ResourceGroupServiceTest and ResourceGroupUsageAggregationTest.
This is possibly a merge conflict in #10201.

Modifications

Fix compilation issues by removing references to non-existent setResourceUsageTransportPublishTopicName method.

@lhotari lhotari mentioned this pull request Apr 17, 2021
Merged
1 task
eolivelli
eolivelli approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

+1

@lhotari
Copy link
Member Author

lhotari commented Apr 17, 2021

/pulsarbot run-failure-checks

@aahmed-se aahmed-se merged commit f986cfe into apache:master Apr 17, 2021
@lhotari lhotari mentioned this pull request Apr 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aahmed-se aahmed-se aahmed-se approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lhotari @aahmed-se @eolivelli