Skip to content

Commit fe547c7

Browse files
author
Masahiro Sakamoto
authored
[fix][client] Shade com.fasterxml.jackson.datatype.* to prevent ClassNotFoundException (#19458)
1 parent cb306c8 commit fe547c7

File tree

3 files changed

+21
-11
lines changed

3 files changed

+21
-11
lines changed

pulsar-client-admin-shaded/pom.xml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123
<include>com.google.protobuf:protobuf-java</include>
124124
<include>com.google.guava:guava</include>
125125
<include>com.google.code.gson:gson</include>
126-
<include>com.fasterxml.jackson.core</include>
126+
<include>com.fasterxml.jackson.*:*</include>
127127
<include>io.netty:*</include>
128128
<include>io.netty.incubator:*</include>
129129
<include>org.apache.pulsar:pulsar-common</include>
@@ -133,7 +133,6 @@
133133
<include>javax.ws.rs:*</include>
134134
<include>jakarta.annotation:*</include>
135135
<include>org.glassfish.hk2*:*</include>
136-
<include>com.fasterxml.jackson.*:*</include>
137136
<include>io.grpc:*</include>
138137
<include>io.perfmark:*</include>
139138
<include>com.yahoo.datasketches:*</include>
@@ -150,6 +149,9 @@
150149
<!-- Issue #6834, Since Netty ByteBuf shaded, we need also shade this module -->
151150
<include>org.apache.pulsar:pulsar-client-messagecrypto-bc</include>
152151
</includes>
152+
<excludes>
153+
<exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
154+
</excludes>
153155
</artifactSet>
154156
<filters>
155157
<filter>
@@ -192,6 +194,9 @@
192194
<relocation>
193195
<pattern>com.fasterxml.jackson</pattern>
194196
<shadedPattern>org.apache.pulsar.shade.com.fasterxml.jackson</shadedPattern>
197+
<excludes>
198+
<exclude>com.fasterxml.jackson.annotation.*</exclude>
199+
</excludes>
195200
</relocation>
196201
<relocation>
197202
<pattern>io.netty</pattern>

pulsar-client-all/pom.xml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,7 @@
151151
<include>com.google.errorprone:*</include>
152152
<include>com.google.j2objc:*</include>
153153
<include>com.google.code.gson:gson</include>
154-
<include>com.fasterxml.jackson.core</include>
155-
<include>com.fasterxml.jackson.module</include>
156-
<include>com.fasterxml.jackson.core:jackson-core</include>
157-
<include>com.fasterxml.jackson.dataformat</include>
154+
<include>com.fasterxml.jackson.*:*</include>
158155
<include>io.netty:netty</include>
159156
<include>io.netty:netty-all</include>
160157
<include>io.netty:netty-tcnative-boringssl-static</include>
@@ -171,7 +168,6 @@
171168
<include>javax.ws.rs:*</include>
172169
<include>jakarta.annotation:*</include>
173170
<include>org.glassfish.hk2*:*</include>
174-
<include>com.fasterxml.jackson.*:*</include>
175171
<include>io.grpc:*</include>
176172
<include>io.perfmark:*</include>
177173
<include>com.yahoo.datasketches:*</include>
@@ -194,6 +190,9 @@
194190
<!-- Issue #6834, Since Netty ByteBuf shaded, we need also shade this module -->
195191
<include>org.apache.pulsar:pulsar-client-messagecrypto-bc</include>
196192
</includes>
193+
<excludes>
194+
<exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
195+
</excludes>
197196
</artifactSet>
198197
<filters>
199198
<filter>
@@ -230,6 +229,9 @@
230229
<relocation>
231230
<pattern>com.fasterxml.jackson</pattern>
232231
<shadedPattern>org.apache.pulsar.shade.com.fasterxml.jackson</shadedPattern>
232+
<excludes>
233+
<exclude>com.fasterxml.jackson.annotation.*</exclude>
234+
</excludes>
233235
</relocation>
234236
<relocation>
235237
<pattern>io.netty</pattern>

pulsar-client-shaded/pom.xml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,7 @@
145145
<include>com.google.errorprone:*</include>
146146
<include>com.google.j2objc:*</include>
147147
<include>com.google.code.gson:gson</include>
148-
<include>com.fasterxml.jackson.core</include>
149-
<include>com.fasterxml.jackson.module</include>
150-
<include>com.fasterxml.jackson.core:jackson-core</include>
151-
<include>com.fasterxml.jackson.dataformat</include>
148+
<include>com.fasterxml.jackson.*:*</include>
152149
<include>io.netty:*</include>
153150
<include>io.netty.incubator:*</include>
154151
<include>io.perfmark:*</include>
@@ -171,6 +168,9 @@
171168
<!-- Issue #6834, Since Netty ByteBuf shaded, we need also shade this module -->
172169
<include>org.apache.pulsar:pulsar-client-messagecrypto-bc</include>
173170
</includes>
171+
<excludes>
172+
<exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
173+
</excludes>
174174
</artifactSet>
175175
<filters>
176176
<filter>
@@ -207,6 +207,9 @@
207207
<relocation>
208208
<pattern>com.fasterxml.jackson</pattern>
209209
<shadedPattern>org.apache.pulsar.shade.com.fasterxml.jackson</shadedPattern>
210+
<excludes>
211+
<exclude>com.fasterxml.jackson.annotation.*</exclude>
212+
</excludes>
210213
</relocation>
211214
<relocation>
212215
<pattern>io.netty</pattern>

0 commit comments

Comments
 (0)