Merged
Conversation
Member
Author
|
@tballison @centic9 What do you think of this new API that wraps the core XSSFWorkbook constructor?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POI has lots of RuntimeExceptions and it would be too much work to change to using checked exceptions. Thousands of method signatures would change and lots of new try/catch changes would be needed in intermediate methods.
We can take some of the most used code paths and provide wrapper APIs that use checked exceptions by wrapping any non-fatal exception/error as a checked exception.