Avoiding needless java.awt.Color dependency in HSSFColor#806
Avoiding needless java.awt.Color dependency in HSSFColor#806JaroslavTulach wants to merge 3 commits intoapache:trunkfrom
java.awt.Color dependency in HSSFColor#806Conversation
|
I'd prefer to make the new constructor public but not to deprecate the old one. |
cd6e232 to
32fea65
Compare
|
thanks - merged |
I see 8bac1b3 - thanks for accepting my change. It will make Enso better. When do you expect next release binary artifacts to be uploaded to Maven central? PS: I was hoping to get a commit authored by me in the POI history to expand on my ASF contributions. Maybe next time. |
|
We don't use git in POI. We use subversion. This GitHub project is a readonly mirror. There is no release expected in the near future. The POI community is small and releases need multiple people to do reviews and get involved in the votes. You can build the jars from source or we have regular builds in CI - https://ci-builds.apache.org/ |
Your web indicates you may perform a release by end of the calendar year (it shows
As a PMC member of Apache NetBeans I can give you non-binding +1 ;-) |
I am currently working on project called Enso. We are making heavy use of Apache POI to parse Excel documents our users are processing.
We are also using GraalVM Native Image to compile our application to native executable. Recently we realized in enso-org/enso#12843 that it is necessary to avoid dependency on
java.desktopmodule.Why Avoiding
java.desktopDependency?Since Java9 the JDK offers tool called jlink. It can be used to create a smaller JDK ready for execution in the cloud and other restricted environments:
java.desktop--jvmflag in process with JNI instantiated JVM enso-org/enso#12843 exclusion ofjava.desktopwas necessaryjava.desktopwas includedExcluding
java.desktopis a good practice anyway - reduces bloat of the final application by tens of megabytes.Patching
HSSFColor--jvmflag in process with JNI instantiated JVM enso-org/enso#12843java.awt.ColorSuch a solution was good short-term workaround, but I don't want to maintain a fork of POI! Hence my goal is to find a way to include the necessary fixes in your project in the long term. Hence the creation of this PR. Can you please consider its acceptance?
Technicalities
HSSFColorjava.awt.Colorjava.desktopintcompatible with handling injava.awt.ColorHSSFColoronjava.desktopis removedOther Fixes
java.desktopdeserves to be removedHSSFColorproposaljava.desktopdependencies