Fix the problem that getHeight() is smaller than the actual value#505
Closed
magnww wants to merge 1 commit intoapache:trunkfrom
Closed
Fix the problem that getHeight() is smaller than the actual value#505magnww wants to merge 1 commit intoapache:trunkfrom
magnww wants to merge 1 commit intoapache:trunkfrom
Conversation
`+ getLeading()` was removed in this commit: apache@5a18307#diff-4cd687c3da36fff3b21d074a27f7bac176c2845b43d37eca3af37fb920baf32cL73 I can't find a reason for the removal. Due to the lack of leading height, the height obtained by this method is much smaller than the actual height (Test with Chinese characters).
Member
|
Can you provide a test or some proof that the existing code is wrong? Can't you call getLeading() yourself and add that value to getHeight() in your own code if you need to? |
Author
|
Test code: The Textbox height set by the After adding getLeading: |
Member
|
added with fccf4a9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




+ getLeading()was removed in this commit: 5a18307#diff-4cd687c3da36fff3b21d074a27f7bac176c2845b43d37eca3af37fb920baf32cL73 I can't find a reason for the removal.Due to the lack of leading height, the height obtained by this method is much smaller than the actual height (Test with Chinese characters).