add an option for RangeCopier.copyRange() also clone styles#179
Closed
xjlin0 wants to merge 4 commits intoapache:trunkfrom
Closed
add an option for RangeCopier.copyRange() also clone styles#179xjlin0 wants to merge 4 commits intoapache:trunkfrom
xjlin0 wants to merge 4 commits intoapache:trunkfrom
Conversation
Member
|
Can you add a test-case which verifies the new option? |
Author
|
Sure, I updated a test case. Here is the passing results: Tests passed: 15 of 15 tests - 2s 304ms. One follow up question for you @centic9 , I found out that the RangeCopier.copyRange() not only cannot copy styles but also cannot copy merged cells. So I am adding options to that function. Do you think the following signature looks good? Where could I also update the document? Thanks! Or should we just forget about the boolean option, make it always copy styles & merged ranges? |
Member
|
Thanks - merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found out that currently RangeCopier.copyRange() only copy values and formulas, however it always pass hardcoded null styleMap to RangeCopier.cloneCellContent(), therefore no styles were copied. Not so sure why, so I added a boolean option for RangeCopier.copyRange() to copy styles.
The MR provides an additional argument on the current RangeCopier.copyRange(), while passing the boolean argument is optional. So it will be compatible with all existing codes using RangeCopier.copyRange().
Tested in my company and the cell styles can be copied by copyRange(). Somehow we also need to include
compile("org.apache.commons:commons-math3:3.0")for it to copy range with styles, probably due to local jar files including.