Dourouc05 patch xwpfabstractfootnoteendnote#156
Closed
dourouc05 wants to merge 3 commits intoapache:trunkfrom
dourouc05:dourouc05-patch-xwpfabstractfootnoteendnote
Closed
Dourouc05 patch xwpfabstractfootnoteendnote#156dourouc05 wants to merge 3 commits intoapache:trunkfrom dourouc05:dourouc05-patch-xwpfabstractfootnoteendnote
dourouc05 wants to merge 3 commits intoapache:trunkfrom
dourouc05:dourouc05-patch-xwpfabstractfootnoteendnote
Conversation
|
Can one of the admins verify this patch? |
Member
|
This doesn't even compile. There is already a createParagraph method. |
Member
|
I merged the other parts of the PR (excluding the broken createParagraph code) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a helper method to directly create a paragraph within a footnote (rather than allowing the note to "eat" an existing CTP paragraph).
Should this function handle the first paragraph as a special case, in order to create a FootnoteRef (in case this is a footnote) and to respect the documentation of https://poi.apache.org/apidocs/dev/org/apache/poi/xwpf/usermodel/XWPFFootnote.html#ensureFootnoteRef-org.apache.poi.xwpf.usermodel.XWPFParagraph-?