Make .splitWhen explicit with SubstreamCancelStrategy.drain#371
Closed
mdedetrich wants to merge 1 commit intoapache:mainfrom
Closed
Make .splitWhen explicit with SubstreamCancelStrategy.drain#371mdedetrich wants to merge 1 commit intoapache:mainfrom
mdedetrich wants to merge 1 commit intoapache:mainfrom
Conversation
c919d79 to
0befeac
Compare
Contributor
Author
|
Im going to close this since the premise is premature, should tackle each of the cases individually if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context of this change is apache/pekko#252. I want to try and get that PR over the finish line for Pekko 1.1.0 and while that PR is not a binary breaking change it is a behaviour breaking change.
What this PR does is it makes any usage of
splitWhenexplicitly useSubstreamCancelStrategy.drain(which is the current default) so that if someone uses pekko-http with a future release of pekko 1.1.0 there won't be any behaviour change. Note that I am not entirely sure if this change makes sense or even if its necessary i.e. it may be the case that whateverSubstreamCancelStrategyyou use it doesn't matter because the variousSubFlow's cannot error (in which case this PR is pointless and can be closed) or it could also be that we really should be explicit about whichSubstreamCancelStrategyto use for correctness reasons (i.e. if hypothetically an error in aSubFlowcan occur then it should always be eitherSubstreamCancelStrategy.drainorSubstreamCancelStrategy.propagate)@jrudolph @raboof @kerr Pinging you here since you have most of the domain knowledge.