Skip to content

Update grpc-core, grpc-interop-testing, ... to 1.68.1#397

Closed
scala-steward-asf[bot] wants to merge 2 commits intomainfrom
update/grpc-core-1.68.1
Closed

Update grpc-core, grpc-interop-testing, ... to 1.68.1#397
scala-steward-asf[bot] wants to merge 2 commits intomainfrom
update/grpc-core-1.68.1

Conversation

@scala-steward-asf
Copy link
Copy Markdown
Contributor

@scala-steward-asf scala-steward-asf bot commented Nov 3, 2024

About this PR

📦 Updates

from 1.68.0 to 1.68.1

📜 GitHub Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (1.68.0).
You might want to review and update them manually.

benchmark-java/build.sbt
docs/src/main/paradox/release-notes/releases-1.1.md
gradle-plugin/src/main/groovy/org/apache/pekko/grpc/gradle/PekkoGrpcPluginExtension.groovy
plugin-tester-java/pom.xml
plugin-tester-scala/pom.xml
sbt-plugin/src/sbt-test/gen-scala-server/00-interop/build.sbt
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.grpc" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.grpc" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

@github-actions github-actions bot added the update label Nov 3, 2024
@pjfanning pjfanning mentioned this pull request Nov 3, 2024
Merged
@raboof
Copy link
Copy Markdown
Member

raboof commented Nov 3, 2024

interesting...

    java.lang.IllegalStateException: Not called from the SynchronizationContext
    	at com.google.common.base.Preconditions.checkState(Preconditions.java:515)
    	at io.grpc.SynchronizationContext.throwIfNotInThisSynchronizationContext(SynchronizationContext.java:134)
    	at io.grpc.internal.ManagedChannelImpl$NameResolverListener.onResult2(ManagedChannelImpl.java:1686)
    	at io.grpc.internal.RetryingNameResolver$RetryingListener.onResult2(RetryingNameResolver.java:107)
    	at io.grpc.NameResolver$Listener2.onAddresses(NameResolver.java:228)
    	at org.apache.pekko.grpc.internal.PekkoDiscoveryNameResolver.$anonfun$lookup$1(PekkoDiscoveryNameResolver.scala:56)
    	at org.apache.pekko.grpc.internal.PekkoDiscoveryNameResolver.$anonfun$lookup$1$adapted(PekkoDiscoveryNameResolver.scala:53)

@pjfanning
Copy link
Copy Markdown
Member

pjfanning commented Nov 3, 2024

A lot of tests failing without timeout exceptions.

Also a lot of these appearing in the test logs (which don't appear in other pekko-grpc builds):

Error:  [11/03/2024 08:12:31.956] [default-pekko.actor.default-dispatcher-6] [org.apache.pekko.dispatch.Dispatcher] Not called from the SynchronizationContext
java.lang.IllegalStateException: Not called from the SynchronizationContext
	at com.google.common.base.Preconditions.checkState(Preconditions.java:515)
	at io.grpc.SynchronizationContext.throwIfNotInThisSynchronizationContext(SynchronizationContext.java:134)
	at io.grpc.internal.ManagedChannelImpl$NameResolverListener.onResult2(ManagedChannelImpl.java:1686)
	at io.grpc.internal.RetryingNameResolver$RetryingListener.onResult2(RetryingNameResolver.java:107)
	at io.grpc.NameResolver$Listener2.onAddresses(NameResolver.java:228)
	at org.apache.pekko.grpc.internal.PekkoDiscoveryNameResolver.$anonfun$lookup$1(PekkoDiscoveryNameResolver.scala:56)
	at org.apache.pekko.grpc.internal.PekkoDiscoveryNameResolver.$anonfun$lookup$1$adapted(PekkoDiscoveryNameResolver.scala:53)
	at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:74)
	at org.apache.pekko.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:73)
	at org.apache.pekko.dispatch.BatchingExecutor$BlockableBatch.$anonfun$run$1(BatchingExecutor.scala:110)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at scala.concurrent.BlockContext$.withBlockContext(BlockContext.scala:85)
	at org.apache.pekko.dispatch.BatchingExecutor$BlockableBatch.run(BatchingExecutor.scala:110)
	at org.apache.pekko.dispatch.TaskInvocation.run(AbstractDispatcher.scala:59)
	at org.apache.pekko.dispatch.ForkJoinExecutorConfigurator$PekkoForkJoinTask.exec(ForkJoinExecutorConfigurator.scala:61)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)

This was referenced Nov 3, 2024
Closed
Closed
@pjfanning
Copy link
Copy Markdown
Member

pjfanning commented Nov 3, 2024

closing in favour of #402

@pjfanning pjfanning closed this Nov 3, 2024
@pjfanning pjfanning deleted the update/grpc-core-1.68.1 branch August 31, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raboof @pjfanning