Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the ssl-config dependency from Apache Pekko by eliminating all deprecated SSL/TLS methods and classes that depended on the external ssl-config library. The change simplifies the codebase by removing legacy APIs that were already deprecated in favor of newer SSLEngine-based approaches.
- Removes all deprecated SSL/TLS methods from Tcp and TLS classes
- Eliminates ssl-config related classes and configuration
- Updates OSGi configuration and project dependencies accordingly
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| stream/src/main/scala/org/apache/pekko/stream/scaladsl/Tcp.scala | Removes deprecated TLS connection methods that used ssl-config |
| stream/src/main/scala/org/apache/pekko/stream/scaladsl/TLS.scala | Removes deprecated TLS factory methods with ssl-config dependency |
| stream/src/main/scala/org/apache/pekko/stream/javadsl/Tcp.scala | Removes Java API deprecated TLS methods and unused utility method |
| stream/src/main/scala/org/apache/pekko/stream/javadsl/TLS.scala | Removes Java API deprecated TLS factory methods |
| stream/src/main/scala/com/typesafe/sslconfig/pekko/util/PekkoLoggerBridge.scala | Completely removes ssl-config logger bridge implementation |
| stream/src/main/scala/com/typesafe/sslconfig/pekko/SSLEngineConfigurator.scala | Completely removes deprecated SSL engine configurator |
| stream/src/main/scala/com/typesafe/sslconfig/pekko/PekkoSSLConfig.scala | Completely removes main ssl-config integration class |
| stream/src/main/resources/reference.conf | Removes ssl-config logger configuration |
| stream/src/main/mima-filters/2.0.x.backwards.excludes/remove-ssl-config.excludes | Adds MiMa filters for removed ssl-config classes and methods |
| stream/src/main/mima-filters/2.0.x.backwards.excludes/remove-deprecated-methods.excludes | Removes filter for deprecated ssl-config method |
| stream-tests/src/test/scala/org/apache/pekko/stream/io/TcpSpec.scala | Removes test for deprecated TLS convenience methods |
| stream-tests/src/test/scala/org/apache/pekko/stream/io/DeprecatedTlsSpec.scala | Completely removes deprecated TLS specification tests |
| project/OSGi.scala | Updates OSGi configuration to remove ssl-config package exports/imports |
| project/Dependencies.scala | Removes ssl-config dependency from project dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
He-Pin
reviewed
Sep 2, 2025
| createSSLEngine: ActorSystem => SSLEngine, // ActorSystem is only needed to support the PekkoSSLConfig legacy, see #21753 | ||
| verifySession: (ActorSystem, SSLSession) => Try[Unit], // ActorSystem is only needed to support the PekkoSSLConfig legacy, see #21753 | ||
| createSSLEngine: () => SSLEngine, | ||
| verifySession: SSLSession => Try[Unit], |
Member
There was a problem hiding this comment.
I think this can be a Try[Done] too.
Member
Author
There was a problem hiding this comment.
I'd prefer to treat that as a separate change. Try[Unit] is the existing return type
Member
There was a problem hiding this comment.
Yes, but that's an internal class, doesn't matter anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.