Skip to content

PARQUET-1832: Travis fails with too long output#777

Merged
gszadovszky merged 1 commit intoapache:masterfrom
gszadovszky:PARQUET-1832
Apr 15, 2020
Merged

PARQUET-1832: Travis fails with too long output#777
gszadovszky merged 1 commit intoapache:masterfrom
gszadovszky:PARQUET-1832

Conversation

@gszadovszky
Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@gszadovszky gszadovszky closed this Apr 6, 2020
@gszadovszky gszadovszky reopened this Apr 6, 2020
Copy link
Copy Markdown
Contributor

@garawalid garawalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a bit verbose for my taste, but Travis is happy again

@gszadovszky gszadovszky merged commit 2d7b63b into apache:master Apr 15, 2020
@gszadovszky
Copy link
Copy Markdown
Contributor Author

I don't know how/why this is reopened. Closing it as it is merged to master and encryption branch is rebased to it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants