Allow reading dictionary encoded boolean#3370
Merged
Fokko merged 2 commits intoapache:masterfrom Dec 19, 2025
Merged
Conversation
I've observed some Parquet files in the wild that contain dictionary encoded boolean values, which is also wild. I don't think we want allow producing this, but I think it would be good to allow reading this. We don't judge.
wgtmac
reviewed
Dec 18, 2025
...-column/src/main/java/org/apache/parquet/column/values/dictionary/PlainValuesDictionary.java
Outdated
Show resolved
Hide resolved
wgtmac
reviewed
Dec 18, 2025
parquet-column/src/test/java/org/apache/parquet/column/values/dictionary/TestDictionary.java
Outdated
Show resolved
Hide resolved
wgtmac
approved these changes
Dec 19, 2025
Contributor
Author
|
Thanks @wgtmac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I've observed some Parquet files in the wild that contain dictionary-encoded boolean values, which is also wild.
I don't think we want to allow producing this, but I think it would be good to allow reading this. We don't judge.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?