GH-3156: Enable vectored IO by default.#3155
Merged
wgtmac merged 1 commit intoapache:masterfrom Mar 3, 2025
Merged
Conversation
Contributor
Author
|
FYI @dongjoon-hyun |
dongjoon-hyun
approved these changes
Feb 14, 2025
Contributor
mukund-thakur
left a comment
There was a problem hiding this comment.
Should we not remove this HADOOP_VECTORED_IO_ENABLED_DEFAULT from code then? This can still lead to confusion.
Contributor
never mind I see you have removed it. |
mukund-thakur
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
We currently had two variables to enable vectored-io,
HADOOP_VECTORED_IO_DEFAULTandHADOOP_VECTORED_IO_ENABLED_DEFAULT,#3128 updated
HADOOP_VECTORED_IO_DEFAULT, which was not being used, so vectoredIO was still turned off by default.Are these changes tested?
Test with in proc Spark app, and ensured that vectored-io is used without the need to set
"parquet.hadoop.vectored.io.enabled", "true"Are there any user-facing changes?