GH-1701: fix double close of ParquetFileWriter#2958
Closed
naude-r wants to merge 1 commit intoapache:masterfrom
Closed
GH-1701: fix double close of ParquetFileWriter#2958naude-r wants to merge 1 commit intoapache:masterfrom
naude-r wants to merge 1 commit intoapache:masterfrom
Conversation
…nd InternalParquetRecordWriter::close via AutoCloseables.uncheckedClose). this causes an exception to be generated on the 2nd close. fixes apache#1701
Contributor
Contributor
|
@naude-r Thanks for raising this PR. Can you elaborate on where you encountered this issue? |
Author
Author
since upgrading to 1.14 we've noticed this when performing a ParquetWriter::close. only reason for upgrading was due to our security scanner highlighting an issue. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ParquetFileWriter::close can be called multiple times (end -> close and InternalParquetRecordWriter::close via AutoCloseables.uncheckedClose). this causes an exception to be generated on the 2nd close.
What changes are included in this PR?
Make ParquetFileWriter::close safe to be called multiple times.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Closes #1701