Rename isReused => isBackingBytesReused

asingh · asingh · commit e00d9b7e4d0e · 2015-06-29T12:45:32.000-07:00
diff --git a/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java b/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
@@ -33,7 +33,7 @@
 
 abstract public class Binary implements Comparable<Binary>, Serializable {
 
-  protected boolean isReused;
+  protected boolean isBackingBytesReused;
 
   // this isn't really something others should extend
   private Binary() { }
@@ -85,14 +85,14 @@ public boolean equals(Object obj) {
   public String toString() {
     return "Binary{" +
         length() +
-        (isReused ? " reused": " constant") +
+        (isBackingBytesReused ? " reused": " constant") +
         " bytes, " +
         Arrays.toString(getBytesUnsafe())
         + "}";
   }
 
   public Binary copy() {
-    if (isReused) {
+    if (isBackingBytesReused) {
       return Binary.fromConstantByteArray(getBytes());
     } else {
       return this;
@@ -103,20 +103,20 @@ public Binary copy() {
    * Signals if backing bytes are owned, and can be modified, by producer of the Binary
    * @return if backing bytes are held on by producer of the Binary
    */
-  public boolean isReused() {
-    return isReused;
+  public boolean isBackingBytesReused() {
+    return isBackingBytesReused;
   }
 
   private static class ByteArraySliceBackedBinary extends Binary {
     private final byte[] value;
     private final int offset;
     private final int length;
 
-    public ByteArraySliceBackedBinary(byte[] value, int offset, int length, boolean isReused) {
+    public ByteArraySliceBackedBinary(byte[] value, int offset, int length, boolean isBackingBytesReused) {
       this.value = value;
       this.offset = offset;
       this.length = length;
-      this.isReused = isReused;
+      this.isBackingBytesReused = isBackingBytesReused;
     }
 
     @Override
@@ -151,7 +151,7 @@ public byte[] getBytesUnsafe() {
 
     @Override
     public Binary slice(int start, int length) {
-      if (isReused) {
+      if (isBackingBytesReused) {
         return Binary.fromReusedByteArray(value, offset + start, length);
       } else {
         return Binary.fromConstantByteArray(value, offset + start, length);
@@ -226,9 +226,9 @@ public static Binary fromConstantByteArray(final byte[] value, final int offset,
   private static class ByteArrayBackedBinary extends Binary {
     private final byte[] value;
 
-    public ByteArrayBackedBinary(byte[] value, boolean isReused) {
+    public ByteArrayBackedBinary(byte[] value, boolean isBackingBytesReused) {
       this.value = value;
-      this.isReused = isReused;
+      this.isBackingBytesReused = isBackingBytesReused;
     }
 
     @Override
@@ -258,7 +258,7 @@ public byte[] getBytesUnsafe() {
 
     @Override
     public Binary slice(int start, int length) {
-      if (isReused) {
+      if (isBackingBytesReused) {
         return Binary.fromReusedByteArray(value, start, length);
       } else {
         return Binary.fromConstantByteArray(value, start, length);
@@ -314,9 +314,9 @@ private static class ByteBufferBackedBinary extends Binary {
     private transient ByteBuffer value;
     private transient byte[] cachedBytes;
 
-    public ByteBufferBackedBinary(ByteBuffer value, boolean isReused) {
+    public ByteBufferBackedBinary(ByteBuffer value, boolean isBackingBytesReused) {
       this.value = value;
-      this.isReused = isReused;
+      this.isBackingBytesReused = isBackingBytesReused;
     }
 
     @Override
@@ -341,7 +341,7 @@ public byte[] getBytes() {
 
       value.mark();
       value.get(bytes).reset();
-      if (!isReused) { // backing buffer might change
+      if (!isBackingBytesReused) { // backing buffer might change
         cachedBytes = bytes;
       }
       return bytes;
