feat(spec): Add DataFileMeta #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Jul 9, 2024
Contributor
Author
|
Thank @Xuanwo for your review, I'll address it later. |
Contributor
Author
|
@Xuanwo hi,I have addressed all above problems |
Member
Thanks, I will find time to review this PR later this week. |
Member
|
cc @SteNicholas and @JingsongLi for another look. |
Contributor
|
Build seems broken now. |
Contributor
Author
|
I've made some modifications to address Clippy's recommendations. The build should now work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10
What I did
Ported DataFileMeta and some associated class into Rust