[2.x] OPENNLP-1785: Ignore ParserConfigurationException in DocumentBuilder when setting XML secure processing feature unsupported on Android#892
Merged
mawiesne merged 1 commit intoapache:opennlp-2.xfrom Nov 22, 2025
Conversation
rzo1
reviewed
Nov 18, 2025
Contributor
|
@soupslurpr Thanks for the contribution! |
a9318cd to
176d908
Compare
rzo1
approved these changes
Nov 21, 2025
mawiesne
requested changes
Nov 21, 2025
Contributor
mawiesne
left a comment
There was a problem hiding this comment.
@soupslurpr Thx for the contribution. I've left minor comments for polishing the PR.
…ocessing feature in DocumentBuilder as it's unsupported on Android
176d908 to
2e4689a
Compare
Contributor
Author
|
@mawiesne Thanks for the feedback! I made the requested changes. Looks good now? |
rzo1
approved these changes
Nov 22, 2025
Contributor
rzo1
left a comment
There was a problem hiding this comment.
Thanks for the PR. Would you mind opening the same change against main too? :)
mawiesne
approved these changes
Nov 22, 2025
Contributor
mawiesne
left a comment
There was a problem hiding this comment.
@soupslurpr Thx for the quick adjustments and this important contribution. Pls, check @rzo1's comment targeting the main branch (3.x)
10 tasks
Contributor
Author
|
Sure thing, here's the PR targeting the main branch: #896 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! When trying to use POSTagger on Android, a ParserConfigurationException is thrown when OpenNLP tries to create a DocumentBuilder. It's thrown when the XML secure processing feature is set. I looked into it, and found out that the feature is not supported on Android.
You can view the comment saying it's not supported in the Android source code here: https://cs.android.com/android/platform/superproject/main/+/main:libcore/luni/src/main/java/javax/xml/parsers/DocumentBuilderFactory.java;l=310-312
I added ignoring the exception when setting that feature so the POSTagger works on Android. I tested it and it now works well.
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.