Skip to content

OPENNLP-1767: Fix sentence detection when an abbreviation overlaps at sentence end#829

Merged
mawiesne merged 1 commit intomainfrom
OPENNLP-1767-Fix-sentence-detection-when-an-abbreviation-overlaps-at-sentence-end
Aug 3, 2025
Merged

OPENNLP-1767: Fix sentence detection when an abbreviation overlaps at sentence end#829
mawiesne merged 1 commit intomainfrom
OPENNLP-1767-Fix-sentence-detection-when-an-abbreviation-overlaps-at-sentence-end

Conversation

@mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Aug 1, 2025

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne self-assigned this Aug 1, 2025
@mawiesne mawiesne added the java Pull requests that update Java code label Aug 1, 2025
@mawiesne mawiesne force-pushed the OPENNLP-1767-Fix-sentence-detection-when-an-abbreviation-overlaps-at-sentence-end branch from 2681b5a to 4b75faf Compare August 1, 2025 12:20
@NishantShri4
Copy link
Contributor

Lgtm. Thanks. However, It seems I don't have permissions to approve.

@mawiesne mawiesne requested a review from NishantShri4 August 1, 2025 13:05
@mawiesne
Copy link
Contributor Author

mawiesne commented Aug 1, 2025

Lgtm. Thanks. However, It seems I don't have permissions to approve.

You should be able to approve. Can you check again?

@NishantShri4
Copy link
Contributor

Lgtm. Thanks. However, It seems I don't have permissions to approve.

You should be able to approve. Can you check again?

Thanks. Done.

Copy link
Contributor

@rzo1 rzo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mawiesne mawiesne force-pushed the OPENNLP-1767-Fix-sentence-detection-when-an-abbreviation-overlaps-at-sentence-end branch 2 times, most recently from c4cdf6a to ce61e40 Compare August 1, 2025 14:41
@mawiesne mawiesne force-pushed the OPENNLP-1767-Fix-sentence-detection-when-an-abbreviation-overlaps-at-sentence-end branch from ce61e40 to a7b8cb8 Compare August 1, 2025 14:43
@mawiesne mawiesne merged commit 55832e4 into main Aug 3, 2025
10 checks passed
@mawiesne mawiesne deleted the OPENNLP-1767-Fix-sentence-detection-when-an-abbreviation-overlaps-at-sentence-end branch August 3, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants