Skip to content

OPENNLP-1762: Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe (OpenNLP 2.x)#822

Merged
rzo1 merged 1 commit intoopennlp-2.xfrom
opennlp-2.x-1762
Jul 23, 2025
Merged

OPENNLP-1762: Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe (OpenNLP 2.x)#822
rzo1 merged 1 commit intoopennlp-2.xfrom
opennlp-2.x-1762

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jul 20, 2025

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Just run mvn clean install with CI profile

@rzo1 rzo1 requested a review from mawiesne July 20, 2025 18:17
@rzo1 rzo1 changed the base branch from main to opennlp-2.x July 20, 2025 18:18
@rzo1 rzo1 requested review from atarora and jzonthemtn July 20, 2025 18:18
@mawiesne mawiesne changed the title |2.x] OPENNLP-1762 - Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe OPENNLP-1762 - Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe Jul 21, 2025
@mawiesne mawiesne changed the title OPENNLP-1762 - Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe OPENNLP-1762 - Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe (OpenNLP 2.x) Jul 21, 2025
@mawiesne mawiesne changed the title OPENNLP-1762 - Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe (OpenNLP 2.x) OPENNLP-1762: Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe (OpenNLP 2.x) Jul 21, 2025
@rzo1
Copy link
Contributor Author

rzo1 commented Jul 21, 2025

Note: This should be merged after release is done.

@rzo1 rzo1 added the build Pull requests that update the build chain. label Jul 21, 2025
@mawiesne
Copy link
Contributor

Note: This should be merged after release is done.

@rzo1 Please rebase the related branch and proceed.

@rzo1
Copy link
Contributor Author

rzo1 commented Jul 23, 2025

No need for a rebase. Can just be merged, commit will be added on top of current target commit.

@rzo1 rzo1 merged commit a937642 into opennlp-2.x Jul 23, 2025
@mawiesne mawiesne deleted the opennlp-2.x-1762 branch August 3, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull requests that update the build chain.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants