Skip to content

OPENNLP-1762: Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe#821

Merged
rzo1 merged 1 commit intomainfrom
fix-mvn-clean-install
Jul 23, 2025
Merged

OPENNLP-1762: Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe#821
rzo1 merged 1 commit intomainfrom
fix-mvn-clean-install

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jul 20, 2025

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Just run mvn clean install to test.

@rzo1 rzo1 requested review from atarora, jzonthemtn and mawiesne July 20, 2025 18:16
@rzo1 rzo1 changed the title OPENNLP-1762 Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe OPENNLP-1762 - Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe Jul 20, 2025
@mawiesne mawiesne changed the title OPENNLP-1762 - Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe OPENNLP-1762: Fix mvn clean install by setting default download property to SourceForge for surefire/failsafe Jul 21, 2025
Copy link
Contributor

@atarora atarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@rzo1 rzo1 merged commit a82ba8f into main Jul 23, 2025
10 checks passed
@mawiesne mawiesne deleted the fix-mvn-clean-install branch July 23, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants