Skip to content

OPENNLP-1760: Make SourceForge URLs in Tests configurable to avoid 403/Rate limiting issues#817

Merged
mawiesne merged 1 commit intomainfrom
allow-base-url-configuration-based-on-properties
Jul 9, 2025
Merged

OPENNLP-1760: Make SourceForge URLs in Tests configurable to avoid 403/Rate limiting issues#817
mawiesne merged 1 commit intomainfrom
allow-base-url-configuration-based-on-properties

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jul 8, 2025

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • [ x Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

see ticket for details

@rzo1 rzo1 requested review from atarora, jzonthemtn and mawiesne July 8, 2025 18:14
@mawiesne mawiesne added build Pull requests that update the build chain. tests Pull requests that add or update test code labels Jul 8, 2025
@mawiesne mawiesne changed the title OPENNLP-1760 - Make SourceForge URLs in Tests Configurable to Avoid 403/Rate Limiting Issues OPENNLP-1760 - Make SourceForge URLs in Tests configurable to avoid 403/Rate limiting issues Jul 8, 2025
@mawiesne mawiesne changed the title OPENNLP-1760 - Make SourceForge URLs in Tests configurable to avoid 403/Rate limiting issues OPENNLP-1760: Make SourceForge URLs in Tests configurable to avoid 403/Rate limiting issues Jul 9, 2025
@mawiesne mawiesne merged commit bbfed25 into main Jul 9, 2025
10 checks passed
@mawiesne mawiesne deleted the allow-base-url-configuration-based-on-properties branch July 9, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull requests that update the build chain. tests Pull requests that add or update test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants