Skip to content

OPENNLP-1759: Optimize computation of hashCode in StringList#814

Merged
mawiesne merged 1 commit intomainfrom
OPENNLP-1759-Optimize-computation-of-hashCode-in-StringList
Jul 10, 2025
Merged

OPENNLP-1759: Optimize computation of hashCode in StringList#814
mawiesne merged 1 commit intomainfrom
OPENNLP-1759-Optimize-computation-of-hashCode-in-StringList

Conversation

@mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Jul 8, 2025

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne requested review from atarora, jzonthemtn and rzo1 July 8, 2025 11:49
@mawiesne mawiesne self-assigned this Jul 8, 2025
@mawiesne mawiesne added the java Pull requests that update Java code label Jul 8, 2025
@mawiesne mawiesne force-pushed the OPENNLP-1759-Optimize-computation-of-hashCode-in-StringList branch 2 times, most recently from 959e21c to e442e03 Compare July 8, 2025 13:00
@mawiesne mawiesne force-pushed the OPENNLP-1759-Optimize-computation-of-hashCode-in-StringList branch from e442e03 to 720efc2 Compare July 8, 2025 14:07
@mawiesne mawiesne merged commit cb4a685 into main Jul 10, 2025
10 checks passed
@mawiesne mawiesne deleted the OPENNLP-1759-Optimize-computation-of-hashCode-in-StringList branch July 10, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants