Skip to content

OPENNLP-1753: Switch to pre-trained Model binaries v1.3 (OpenNLP 2.x)#810

Merged
mawiesne merged 1 commit intoopennlp-2.xfrom
OPENNLP-1753-Switch-to-pre-trained-Model-binaries-v1.3
Jul 7, 2025
Merged

OPENNLP-1753: Switch to pre-trained Model binaries v1.3 (OpenNLP 2.x)#810
mawiesne merged 1 commit intoopennlp-2.xfrom
OPENNLP-1753-Switch-to-pre-trained-Model-binaries-v1.3

Conversation

@mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Jul 7, 2025

Change

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne requested a review from rzo1 July 7, 2025 12:59
@mawiesne mawiesne added dependencies Pull requests that update a dependency file java Pull requests that update Java code tests Pull requests that add or update test code labels Jul 7, 2025
@mawiesne mawiesne changed the base branch from main to opennlp-2.x July 7, 2025 12:59
@mawiesne mawiesne changed the title OPENNLP-1753: Switch to pre-trained Model binaries v1.3 OPENNLP-1753: Switch to pre-trained Model binaries v1.3 (OpenNLP 2.x) Jul 7, 2025
@mawiesne
Copy link
Contributor Author

mawiesne commented Jul 7, 2025

@rzo1 Why are there no CICD checks / actions run here on this branch / PR ?

@rzo1
Copy link
Contributor

rzo1 commented Jul 7, 2025

@rzo1 Why are there no CICD checks / actions run here on this branch / PR ?

#811

@mawiesne mawiesne force-pushed the OPENNLP-1753-Switch-to-pre-trained-Model-binaries-v1.3 branch 3 times, most recently from 1e54afd to 97e4f4c Compare July 7, 2025 16:39
- provides and adapts PR #799 for OpenNLP 2.x maintenance branch
- adjusts version strings
- adjusts index.html template to latest v1.3 copy for DownloadParserTest
- adjusts examples in Dev manual
@mawiesne mawiesne force-pushed the OPENNLP-1753-Switch-to-pre-trained-Model-binaries-v1.3 branch from 97e4f4c to f4ed8fe Compare July 7, 2025 16:42
@mawiesne mawiesne merged commit adc38fa into opennlp-2.x Jul 7, 2025
10 checks passed
@mawiesne mawiesne deleted the OPENNLP-1753-Switch-to-pre-trained-Model-binaries-v1.3 branch July 7, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code tests Pull requests that add or update test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants