Skip to content

OPENNLP-1745: SentenceDetector - Add Junit test for useTokenEnd = false (OpenNLP 2.x)#809

Merged
mawiesne merged 1 commit intoopennlp-2.xfrom
OPENNLP-1745-SentenceDetector-Add-documentation-and-tests-for-useTokenEnd=false
Jul 7, 2025
Merged

OPENNLP-1745: SentenceDetector - Add Junit test for useTokenEnd = false (OpenNLP 2.x)#809
mawiesne merged 1 commit intoopennlp-2.xfrom
OPENNLP-1745-SentenceDetector-Add-documentation-and-tests-for-useTokenEnd=false

Conversation

@mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Jul 7, 2025

Change

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne requested a review from rzo1 July 7, 2025 12:40
@mawiesne mawiesne added java Pull requests that update Java code tests Pull requests that add or update test code labels Jul 7, 2025
@rzo1
Copy link
Contributor

rzo1 commented Jul 7, 2025

Checkstyle violations: Error: src/main/java/opennlp/tools/cmdline/sentdetect/TrainingParams.java:[49] (sizes) LineLength: Line is longer than 110 characters (found 111)

@mawiesne mawiesne changed the title OPENNLP-1745: SentenceDetector - Add Junit test for useTokenEnd = false OPENNLP-1745: SentenceDetector - Add Junit test for useTokenEnd = false (OpenNLP 2.x) Jul 7, 2025
@mawiesne mawiesne force-pushed the OPENNLP-1745-SentenceDetector-Add-documentation-and-tests-for-useTokenEnd=false branch from 8169b47 to 1e6fffb Compare July 7, 2025 13:04
@mawiesne mawiesne force-pushed the OPENNLP-1745-SentenceDetector-Add-documentation-and-tests-for-useTokenEnd=false branch from 1e6fffb to c52dea8 Compare July 7, 2025 16:26
@mawiesne mawiesne merged commit 5fb0530 into opennlp-2.x Jul 7, 2025
10 checks passed
@mawiesne mawiesne deleted the OPENNLP-1745-SentenceDetector-Add-documentation-and-tests-for-useTokenEnd=false branch July 7, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code tests Pull requests that add or update test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants