Skip to content

OPENNLP-1755 - Align Module Names with OpenNLP Models Name#803

Merged
rzo1 merged 1 commit intomainfrom
OPENNLP-1755-Align-Module-Names-with-OpenNLP-Models-Name
Jun 30, 2025
Merged

OPENNLP-1755 - Align Module Names with OpenNLP Models Name#803
rzo1 merged 1 commit intomainfrom
OPENNLP-1755-Align-Module-Names-with-OpenNLP-Models-Name

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jun 27, 2025

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

[INFO] Apache OpenNLP ..................................... SUCCESS [  2.982 s]
[INFO] Apache OpenNLP :: API .............................. SUCCESS [  0.763 s]
[INFO] Apache OpenNLP :: Core ............................. SUCCESS [  0.136 s]
[INFO] Apache OpenNLP :: Core :: ML ....................... SUCCESS [  0.094 s]
[INFO] Apache OpenNLP :: Core :: ML :: Commons ............ SUCCESS [  1.145 s]
[INFO] Apache OpenNLP :: Core :: ML :: Maximum Entropy .... SUCCESS [  2.096 s]
[INFO] Apache OpenNLP :: Core :: ML :: Naive Bayes ........ SUCCESS [  1.064 s]
[INFO] Apache OpenNLP :: Core :: ML :: Perceptron ......... SUCCESS [  1.010 s]
[INFO] Apache OpenNLP :: Core :: Runtime .................. SUCCESS [  4.311 s]
[INFO] Apache OpenNLP :: Core :: ML :: Deep Learning ...... SUCCESS [  0.945 s]
[INFO] Apache OpenNLP :: Core :: ML :: Deep Learning (GPU)  SUCCESS [  0.070 s]
[INFO] Apache OpenNLP :: Core :: Models ................... SUCCESS [  0.896 s]
[INFO] Apache OpenNLP :: Core :: Formats .................. SUCCESS [  2.111 s]
[INFO] Apache OpenNLP :: Core :: CLI ...................... SUCCESS [  1.489 s]
[INFO] Apache OpenNLP :: Tools ............................ SUCCESS [  1.211 s]
[INFO] Apache OpenNLP :: Extensions ....................... SUCCESS [  0.033 s]
[INFO] Apache OpenNLP :: Morfologik Addon ................. SUCCESS [  0.750 s]
[INFO] Apache OpenNLP :: UIMA Annotators .................. SUCCESS [  1.294 s]
[INFO] Apache OpenNLP :: Distribution ..................... SUCCESS [ 26.709 s]
[INFO] Apache OpenNLP :: Documentation .................... SUCCESS [  1.596 s]

@rzo1 rzo1 requested review from Copilot and mawiesne and removed request for Copilot June 27, 2025 06:14
Copilot AI reviewed Jun 27, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Maven project name definitions to align module names with the standardized OpenNLP model naming convention. The changes update the name tags in various pom.xml files to incorporate a hierarchical structure using the "::" separator.

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pom.xml Updated project name for overall consistency.
opennlp-tools/pom.xml Renamed module to follow the "::" convention.
opennlp-extensions/pom.xml Renamed module to align with naming updates.
opennlp-extensions/opennlp-uima/pom.xml Updated module name to include "::" separator.
opennlp-extensions/opennlp-morfologik/pom.xml Updated module naming for consistency.
opennlp-docs/pom.xml Updated documentation module name to the new format.
opennlp-distr/pom.xml Renamed distribution module to follow new naming convention.
opennlp-core/pom.xml Updated core module name to align with new standards.
opennlp-core/opennlp-runtime/pom.xml Renamed runtime module for clear hierarchy.
opennlp-core/opennlp-models/pom.xml Updated model module name to match standards.
opennlp-core/opennlp-ml/pom.xml Updated machine learning module name with new naming pattern.
opennlp-core/opennlp-ml/opennlp-ml-perceptron/pom.xml Renamed perceptron submodule for consistency.
opennlp-core/opennlp-ml/opennlp-ml-maxent/pom.xml Updated maximum entropy module name as per new convention.
opennlp-core/opennlp-ml/opennlp-ml-commons/pom.xml Renamed ML commons module for clarity.
opennlp-core/opennlp-ml/opennlp-ml-bayes/pom.xml Updated naive Bayes module name to align with new naming pattern.
opennlp-core/opennlp-ml/opennlp-dl/pom.xml Renamed deep learning module for consistency.
opennlp-core/opennlp-ml/opennlp-dl-gpu/pom.xml Updated deep learning (GPU) module name accordingly.
opennlp-core/opennlp-formats/pom.xml Renamed formats module to support consistent naming.
opennlp-core/opennlp-cli/pom.xml Updated CLI module name to reflect new naming style.
opennlp-api/pom.xml Renamed API module to match updated naming conventions.

mawiesne
mawiesne approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@mawiesne mawiesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx @rzo1

@mawiesne mawiesne added the build Pull requests that update the build chain. label Jun 30, 2025
@rzo1 rzo1 merged commit 7b6e06a into main Jun 30, 2025
10 checks passed
@mawiesne mawiesne deleted the OPENNLP-1755-Align-Module-Names-with-OpenNLP-Models-Name branch July 7, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jzonthemtn jzonthemtn jzonthemtn approved these changes

@mawiesne mawiesne mawiesne approved these changes

Assignees

@rzo1 rzo1

Labels

build Pull requests that update the build chain.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rzo1 @jzonthemtn @mawiesne