Skip to content

Fix Eval Build for OpenNLP 3.x#794

Merged
rzo1 merged 2 commits intomainfrom
add-junit-to-api
Jun 25, 2025
Merged

Fix Eval Build for OpenNLP 3.x#794
rzo1 merged 2 commits intomainfrom
add-junit-to-api

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jun 20, 2025

…execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.3:test (default-test) on project opennlp-api: groups/excludedGroups require TestNG, JUnit48+ or JUnit 5 (a specific engine required on classpath) on project test classpath"
@rzo1 rzo1 changed the title Fix Eval Build for OpenNLP 3.x Draft: Fix Eval Build for OpenNLP 3.x Jun 20, 2025
@rzo1
Copy link
Contributor Author

rzo1 commented Jun 20, 2025

This needs some more love. The Missing JUnit engine was the First step, but we have a few ClassNotFoundExceptions indicating Missing (runtime) deps for eval. Needs deeper investigation.

Copy link
Contributor

@mawiesne mawiesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for inspecting & fixing the eval setup.

@mawiesne mawiesne changed the title Draft: Fix Eval Build for OpenNLP 3.x Fix Eval Build for OpenNLP 3.x Jun 25, 2025
@mawiesne mawiesne added the tests Pull requests that add or update test code label Jun 25, 2025
@mawiesne mawiesne requested a review from jzonthemtn June 25, 2025 06:01
@rzo1
Copy link
Contributor Author

rzo1 commented Jun 25, 2025

@rzo1 rzo1 merged commit 1fb064d into main Jun 25, 2025
10 of 17 checks passed
@rzo1 rzo1 deleted the add-junit-to-api branch June 25, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that add or update test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants