OPENNLP-385: Add unit tests for OpenNLP UIMA component#748
Merged
Conversation
a1cd791 to
1ef0d9f
Compare
6555efd to
59c9b03
Compare
kinow
approved these changes
Feb 13, 2025
rzo1
approved these changes
Feb 13, 2025
Contributor
rzo1
left a comment
There was a problem hiding this comment.
lgtm - thanks.
Only question: Can we add the CDN available annotation to skip in case asf-cdn or sf are unavailable?
tteofili
approved these changes
Feb 13, 2025
- adapts and reactivates AnnotatorsInitializationTest by T. Teofili, originally provided in JIRA issue, to execute for all xml descriptors - converts AnnotatorsInitializationTest to several integration tests executed via Maven failsafe plugin - adds Parser.xml to 'test-descriptors' - adds more test classes - configures Maven resource filtering for xml 'test-descriptors' - moves 'ci' profile to upper-level pom.xml for re-use in opennlp-uima component - adds simplelogger.properties to test resources to avoid log spam during build caused by internal UIMA logger config
59c9b03 to
4a89fa3
Compare
Contributor
Author
It's reflected via latest commit / push. |
rzo1
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
AnnotatorsInitializationTestby T. Teofili, originally provided in JIRA issue, to execute for all xml descriptors via true ITsParser.xmlto test-descriptors@Overrideannotations here and thereCode Coverage (with PR)
Rows: package, class, method, line, branch

Code Coverage (previously / without PR)
Rows: package, class, method, line, branch

Tasks
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.