Skip to content

OPENNLP-1688 - Add GH action to test binaries (*nix + win) in GH actions#740

Merged
rzo1 merged 1 commit intomainfrom
OPENNLP-1688
Jan 20, 2025
Merged

OPENNLP-1688 - Add GH action to test binaries (*nix + win) in GH actions#740
rzo1 merged 1 commit intomainfrom
OPENNLP-1688

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jan 17, 2025

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

see for further details: https://issues.apache.org/jira/projects/OPENNLP/issues/OPENNLP-1688

Can be enhanced with different shell exec tests later.

Possible enhancement:

  • Get the bats action whitelisted and we can do a matrix build for osx / ubuntu

@rzo1 rzo1 self-assigned this Jan 17, 2025
@rzo1
Copy link
Contributor Author

rzo1 commented Jan 17, 2025

Note: Normal actions fail unrelated due to unavailable sourceforge (403), see #741

Copy link
Contributor

@mawiesne mawiesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent addition @rzo1!

@rzo1 rzo1 merged commit 6d0d8c2 into main Jan 20, 2025
10 checks passed
@rzo1 rzo1 deleted the OPENNLP-1688 branch January 20, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants