OPENNLP-1687: Remove quotes around $HEAP in opennlp tools shell script#734
Merged
mawiesne merged 1 commit intoapache:mainfrom Jan 5, 2025
chenrui333:fix-build
Merged
OPENNLP-1687: Remove quotes around $HEAP in opennlp tools shell script#734mawiesne merged 1 commit intoapache:mainfrom chenrui333:fix-build
mawiesne merged 1 commit intoapache:mainfrom
chenrui333:fix-build
Conversation
…ss` error Signed-off-by: Rui Chen <rui@chenrui.dev>
$HEAP to fix Could not find or load main class error
mawiesne
approved these changes
Jan 5, 2025
Contributor
|
@chenrui333 Thx for finding this and providing a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
Previously, $HEAP was wrapped in quotes when passed to java, causing an empty or incorrect argument to be parsed, which could trigger a “Could not find or load main class” error (e.g., in Homebrew environments). By removing the quotes, $HEAP is now passed correctly, ensuring Java recognizes the classpath and preventing the ClassNotFoundException. This also allows multiple or custom JVM arguments (e.g., -Xmx512m -Xms256m) to be supplied through $JAVA_HEAP if desired.
relates to Homebrew/homebrew-core#202547