Skip to content

OPENNLP-1670: Disable releases for apache.snapshots repo#711

Merged
rzo1 merged 1 commit intoapache:mainfrom
adoroszlai:OPENNLP-1670
Dec 16, 2024
Merged

OPENNLP-1670: Disable releases for apache.snapshots repo#711
rzo1 merged 1 commit intoapache:mainfrom
adoroszlai:OPENNLP-1670

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Dec 14, 2024

What changes were proposed in this pull request?

The Apache snapshot repository should be enabled only for snapshots.

enabled: true or false for whether this repository is enabled for the respective type (releases or snapshots). By default this is true. (source)

$ mvn -N --batch-mode eu.maveniverse.maven.plugins:toolbox:list-repositories
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------------------< org.apache.opennlp:opennlp >---------------------
[INFO] Building Apache OpenNLP Reactor 2.5.2-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- toolbox:0.6.0:list-repositories (default-cli) @ opennlp ---
[INFO] Remote repositories used by project org.apache.opennlp:opennlp:pom:2.5.2-SNAPSHOT.
[INFO]  * central (https://repo.maven.apache.org/maven2/, default, releases)
[INFO]    First introduced on root
[INFO]  * apache.snapshots (https://repository.apache.org/snapshots, default, releases+snapshots)
[INFO]    First introduced on root
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

https://issues.apache.org/jira/browse/OPENNLP-1670

How was this patch tested?

$ mvn -N --batch-mode eu.maveniverse.maven.plugins:toolbox:list-repositories
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------------------< org.apache.opennlp:opennlp >---------------------
[INFO] Building Apache OpenNLP Reactor 2.5.2-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- toolbox:0.6.0:list-repositories (default-cli) @ opennlp ---
[INFO] Remote repositories used by project org.apache.opennlp:opennlp:pom:2.5.2-SNAPSHOT.
[INFO]  * central (https://repo.maven.apache.org/maven2/, default, releases)
[INFO]    First introduced on root
[INFO]  * apache.snapshots (https://repository.apache.org/snapshots, default, snapshots)
[INFO]    First introduced on root

This was referenced Dec 14, 2024
Merged
Merged
Merged
@adoroszlai
Copy link
Contributor Author

adoroszlai commented Dec 16, 2024

Thanks @jzonthemtn, @kinow, @mawiesne for approving these pull requests. Can you please let me know if there is anything left before they can be merged?

@rzo1 rzo1 merged commit 9ba57ce into apache:main Dec 16, 2024
@adoroszlai adoroszlai deleted the OPENNLP-1670 branch December 16, 2024 09:55
@adoroszlai
Copy link
Contributor Author

adoroszlai commented Dec 16, 2024

@rzo1 thanks for merging the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinow kinow kinow approved these changes

@mawiesne mawiesne mawiesne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adoroszlai @kinow @mawiesne @rzo1