OPENNLP-1659 - Enhancements for DownloadUtil#697
Merged
Conversation
59bfb9d to
0191a9e
Compare
mawiesne
requested changes
Nov 28, 2024
opennlp-tools/src/test/java/opennlp/tools/util/AbstractDownloadUtilTest.java
Show resolved
Hide resolved
0191a9e to
99e0b5f
Compare
a19190e to
918f6a0
Compare
mawiesne
approved these changes
Nov 28, 2024
Contributor
|
@rzo1 minor-isch conflict, pls rebase |
- Make the BASE_URL and MODEL_URI_PATH configurable via System properties in order to be backwards compatible if models are removed from the release area of OpenNLP / ASF CDN - Make the OPENNLP_DOWNLOAD_HOME configurable, i.e. for tests in CI environments. This can also be useful for OpenNLP devs to avoid cleaning models in their user home. - Replace hard coded file separators for multi OS support - Log a DEBUG message if the model file already exists and the download is skipped. - Adds a test case to verify that models are not downloaded twice (if they exist) by testing for the related LOG output using LogCaptor. - Replaces slf4j-simple with logback (from LogCaptor) for further testing of specific output
918f6a0 to
45c7d9a
Compare
mawiesne
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note: