Skip to content

OPENNLP-1600 - Ability to disable POS mapper#649

Merged
rzo1 merged 1 commit intomainfrom
OPENNLP-1600-Ability-to-disable-POS-mapper
Sep 9, 2024
Merged

OPENNLP-1600 - Ability to disable POS mapper#649
rzo1 merged 1 commit intomainfrom
OPENNLP-1600-Ability-to-disable-POS-mapper

Conversation

@rzo1
Copy link
Contributor

@rzo1 rzo1 commented Sep 5, 2024

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

This PR introduces a new POSTagFormat#CUSTOM which will disable the automatic format mapping in POSTaggerME. In addition, it opens up the format mapper variable to be protected, so people can override as needed.

fyi @reckart

@rzo1 rzo1 merged commit a1c46d1 into main Sep 9, 2024
@mawiesne mawiesne deleted the OPENNLP-1600-Ability-to-disable-POS-mapper branch September 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants