OPENNLP-1539 - Introduce parameter for POSTaggerME to configure output POS tag format#601
Merged
OPENNLP-1539 - Introduce parameter for POSTaggerME to configure output POS tag format#601
Conversation
Contributor
Author
|
Note: The currently failing tests are unrelated to the actual change: Error: ChunkerModelLoaderTest.initResources:43->lambda$initResources$0:47 Runtime java.io.IOException: Server returned HTTP response code: 503 for URL: https://opennlp.sourceforge.net/models-1.5/en-chunker.bin
Error: TokenNameFinderModelLoaderTest.initResources:43->lambda$initResources$0:47 Runtime java.io.IOException: Server returned HTTP response code: 503 for URL: https://opennlp.sourceforge.net/models-1.5/en-ner-location.bin
Error: TokenNameFinderModelTest.testNERWithPOSModelV15:122->AbstractModelLoaderTest.downloadVersion15Model:41->AbstractModelLoaderTest.downloadModel:57 » IO Server returned HTTP response code: 503 for URL: https://opennlp.sourceforge.net/models-1.5/pt-pos-perceptron.bin |
jzonthemtn
reviewed
May 23, 2024
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormatMapper.java
Show resolved
Hide resolved
jzonthemtn
approved these changes
May 23, 2024
Contributor
|
@rzo1 Did you run into any weirdness with the older Sourceforge models? |
Contributor
Author
|
Need to add an test for it ;-) |
mawiesne
requested changes
May 24, 2024
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormatMapper.java
Outdated
Show resolved
Hide resolved
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormatMapper.java
Outdated
Show resolved
Hide resolved
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormatMapper.java
Outdated
Show resolved
Hide resolved
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormatMapper.java
Show resolved
Hide resolved
Contributor
|
Thx @rzo1 - I left some comments to improve clarity of the doc for the changes in the API. |
rzo1
commented
May 24, 2024
opennlp-tools/src/main/java/opennlp/tools/postag/POSTagFormatMapper.java
Outdated
Show resolved
Hide resolved
…t POS tag format
Contributor
Author
Added tests. They look good. |
mawiesne
approved these changes
May 24, 2024
kinow
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
This is a Draft open for feedback on implementing compatibility with older PENN-based POS models from Sourceforge.
However, it is ready for review / ideas and comments / thoughts.