Skip to content

Conversation

@kenwoodjw
Copy link
Contributor

Which issue does this PR close?

Closes #4108

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@kenwoodjw kenwoodjw requested a review from Xuanwo as a code owner August 11, 2025 06:17
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Aug 11, 2025
Signed-off-by: kenwoodjw <blackxin55+@gmail.com>
@kenwoodjw kenwoodjw force-pushed the fix/azblob-base64-validation-error branch from e6bb2ba to 12a2943 Compare August 11, 2025 06:23
Signed-off-by: kenwoodjw <blackxin55+@gmail.com>
@Xuanwo
Copy link
Member

Xuanwo commented Aug 11, 2025

The Node.js diff seems not related. cc @kingsword09, would you like to take another look?

@kingsword09
Copy link
Contributor

The Node.js diff seems not related. cc @kingsword09, would you like to take another look?

Because the update in napi-derive changed the way commented code is generated:
napi-rs/napi-rs@bcef141

@Xuanwo Xuanwo changed the title fix azblob base64 validation fix(services/azblob): Fix azblob base64 validation Aug 12, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good fix to me.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2025
@Xuanwo Xuanwo merged commit c60d705 into apache:main Aug 12, 2025
339 of 340 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AzBlob: Confusing error message if access_key can't be decoded as base-64

3 participants