Skip to content

ci: refactor nodejs ci workflow#6491

Merged
Xuanwo merged 8 commits intoapache:mainfrom
kingsword09:ci-nodejs-check
Aug 8, 2025
Merged

ci: refactor nodejs ci workflow#6491
Xuanwo merged 8 commits intoapache:mainfrom
kingsword09:ci-nodejs-check

Conversation

@kingsword09
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #6489.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@kingsword09 kingsword09 marked this pull request as draft August 8, 2025 00:11
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" labels Aug 8, 2025
@kingsword09
Copy link
Copy Markdown
Contributor Author

cc @Xuanwo

Testing with publish dry run works as expected: https://github.com/apache/opendal/actions/runs/16825258046/job/47660615280?pr=6491

Two workflow_dispatch events have been added:

  • nodejs-publish-dry-run: for pre-release testing
  • nodejs-publish: for production releases

@kingsword09 kingsword09 marked this pull request as ready for review August 8, 2025 08:34
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 8, 2025
@Xuanwo
Copy link
Copy Markdown
Member

Xuanwo commented Aug 8, 2025

So cool!

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look good to me, thank you for working on this!

- "core/**"
- ".github/workflows/ci_bindings_nodejs.yml"
workflow_dispatch:
inputs:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we have two workflows (like other langauge): ci_bindings_nodejs.yml and release_nodejs, can we?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

"files": [
"opendal.linux-arm64-gnu.node"
],
"description": "Apache OpenDAL: Access data freely",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note our vision has changed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed: "Apache OpenDAL: One Layer, All Storage."

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 8, 2025
@kingsword09
Copy link
Copy Markdown
Contributor Author

kingsword09 commented Aug 8, 2025

@kingsword09 kingsword09 requested a review from Xuanwo August 8, 2025 13:35
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice! Thank you @kingsword09.

@Xuanwo Xuanwo merged commit c7809e7 into apache:main Aug 8, 2025
73 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2025
@kingsword09 kingsword09 deleted the ci-nodejs-check branch August 8, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release jobs for oli and node.js failed

2 participants