chore(bindings/nodejs): upgrade deps napi-rs to 3.0#6482
Merged
Xuanwo merged 4 commits intoapache:mainfrom Aug 4, 2025
Merged
Conversation
Xuanwo
reviewed
Aug 4, 2025
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 8 | ||
| version: 10.14.0 |
Member
There was a problem hiding this comment.
Change this can introduce a big changes to pnpm.lock, how about we bump this first?
Contributor
Author
There was a problem hiding this comment.
I noticed the official napi template uses pnpm 10, so I upgraded here. Now I’ll revert this change as suggested.
Xuanwo
reviewed
Aug 4, 2025
| with: | ||
| toolchain: stable | ||
| targets: ${{ matrix.settings.target }} | ||
| - name: Cache cargo |
Member
There was a problem hiding this comment.
I suggest we don't cache here. Our release workflow only run twice a month.
| .cargo-cache | ||
| target/ | ||
| key: ${{ matrix.settings.target }}-cargo-${{ matrix.settings.host }} | ||
| - uses: goto-bus-stop/setup-zig@v2 |
Member
There was a problem hiding this comment.
Please check can we use this action first. And I remember that we have a zig related action, are we using the same one?
| with: | ||
| toolchain: stable | ||
| targets: ${{ matrix.settings.target }} | ||
| - name: Cache cargo |
| cache: pnpm | ||
| cache-dependency-path: "bindings/nodejs/pnpm-lock.yaml" | ||
| - name: Corepack | ||
| run: npm i -g --force corepack@latest && corepack enable |
Contributor
Author
There was a problem hiding this comment.
Yes, the official documentation URL is as follows: docs
Xuanwo
approved these changes
Aug 4, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6475.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?