Skip to content

fix(core): Only run size tests on 64bit platforms#6078

Merged
Xuanwo merged 1 commit intoapache:mainfrom
cryptomilk:asn-test
Apr 22, 2025
Merged

fix(core): Only run size tests on 64bit platforms#6078
Xuanwo merged 1 commit intoapache:mainfrom
cryptomilk:asn-test

Conversation

@cryptomilk
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #6077.

Rationale for this change

This only runs the assert_size tests on 64bit platforms. They have hardcoded values for that platform only.

What changes are included in this PR?

Are there any user-facing changes?

Nope

@cryptomilk cryptomilk requested a review from Xuanwo as a code owner April 22, 2025 12:59
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Apr 22, 2025
@cryptomilk
Copy link
Copy Markdown
Contributor Author

I've started a build with this patch: https://koji.fedoraproject.org/koji/taskinfo?taskID=131860342

Copy link
Copy Markdown
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cryptomilk for this fix!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 22, 2025
@Xuanwo Xuanwo merged commit f7989bd into apache:main Apr 22, 2025
276 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Failing test on 32bit platform

2 participants