feat(bindings/ruby): add lister#5600
Merged
Xuanwo merged 3 commits intoapache:mainfrom Feb 10, 2025
erickguan:ruby-binding-list
Merged
feat(bindings/ruby): add lister#5600Xuanwo merged 3 commits intoapache:mainfrom erickguan:ruby-binding-list
Xuanwo merged 3 commits intoapache:mainfrom
erickguan:ruby-binding-list
Conversation
Xuanwo
reviewed
Feb 8, 2025
bindings/ruby/src/operator.rs
Outdated
| } | ||
|
|
||
| /// Lists the directory recursively. | ||
| pub fn scan(ruby: &Ruby, rb_self: &Self, path: String) -> Result<Lister, Error> { |
Member
There was a problem hiding this comment.
Hi, scan has been deprecated, and bindings should not expose such an API. Instead, the list function should accept an argument that allows setting recursive: true.
Xuanwo
approved these changes
Feb 10, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @erickguan for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5227.