Skip to content

Commit 85c3803

Browse files
authored
fix(serivces/gcs): Gcs doesn't support read with if_(un)modified_since (#5537)
1 parent f951963 commit 85c3803

2 files changed

Lines changed: 0 additions & 16 deletions

File tree

core/src/services/gcs/backend.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,8 +369,6 @@ impl Access for GcsBackend {
369369

370370
read_with_if_match: true,
371371
read_with_if_none_match: true,
372-
read_with_if_modified_since: true,
373-
read_with_if_unmodified_since: true,
374372

375373
write: true,
376374
write_can_empty: true,

core/src/services/gcs/core.rs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -203,20 +203,6 @@ impl GcsCore {
203203
req = req.header(http::header::RANGE, range.to_header());
204204
}
205205

206-
if let Some(if_modified_since) = args.if_modified_since() {
207-
req = req.header(
208-
IF_MODIFIED_SINCE,
209-
format_datetime_into_http_date(if_modified_since),
210-
);
211-
}
212-
213-
if let Some(if_unmodified_since) = args.if_unmodified_since() {
214-
req = req.header(
215-
IF_UNMODIFIED_SINCE,
216-
format_datetime_into_http_date(if_unmodified_since),
217-
);
218-
}
219-
220206
let req = req.body(Buffer::new()).map_err(new_request_build_error)?;
221207

222208
Ok(req)

0 commit comments

Comments
 (0)