Improved: Don't need to show files names in UI messages (OFBIZ-12884)

JacquesLeRoux · JacquesLeRoux · commit b1cf4ef3e18f · 2024-02-01T20:36:55.000+01:00
We don't need to show files names in UI messages. it's already in log.
It does not help users and rather confuse them.

Conflict handled by hand
diff --git a/framework/minilang/src/main/java/org/apache/ofbiz/minilang/SimpleMethod.java b/framework/minilang/src/main/java/org/apache/ofbiz/minilang/SimpleMethod.java
@@ -457,7 +457,13 @@ public String exec(MethodContext methodContext) throws MiniLangException {
             finished = runSubOps(methodOperations, methodContext);
         } catch (Throwable t) {
             // make SURE nothing gets thrown through
-            String errMsg = UtilProperties.getMessage(SimpleMethod.err_resource, "simpleMethod.error_running", locale) + ": " + t.getMessage();
+            String errorMessage = t.getMessage();
+            if (errorMessage.contains("File = file") && errorMessage.contains("Events.xml")) {
+                String noFile = errorMessage.substring(errorMessage.indexOf("File = file"),
+                        errorMessage.indexOf("Events.xml") + "Events.xml".length());
+                errorMessage = errorMessage.replace(noFile, "");
+            }
+            String errMsg = UtilProperties.getMessage(SimpleMethod.err_resource, "simpleMethod.error_running", locale) + ": " + errorMessage;
             if (methodContext.isTraceOn()) {
                 outputTraceMessage(methodContext, "An exception was thrown while running sub-elements, error message was:", errMsg);
             }
