Skip to content

testing/ltp: Increase Stack Size#2888

Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom
lupyuen2:ltp-stack
Dec 16, 2024
Merged

testing/ltp: Increase Stack Size#2888
xiaoxiang781216 merged 1 commit intoapache:masterfrom
lupyuen2:ltp-stack

Conversation

@lupyuen
Copy link
Copy Markdown
Member

@lupyuen lupyuen commented Dec 16, 2024

Summary

Inside CI Build risc-v-05: rv-virt:citest fails with a Stack Overflow at ltp_interfaces_pthread_barrierattr_init_2_1:

This PR doubles the Stack Size for testing/ltp (from 4096 bytes to 8192), so that rv-virt:citest completes successfully.

Impact

With this PR, rv-virt:citest will complete successfully.

Testing

We tested rv-virt:citest on Docker:

https://gist.github.com/lupyuen/3688826ed676971536249509ceefe834

sudo docker run \
  -it \
  ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
  /bin/bash
cd
git clone https://github.com/apache/nuttx
git clone https://github.com/lupyuen2/wip-nuttx-apps --branch ltp-stack apps
pushd nuttx ; echo NuttX Source: https://github.com/apache/nuttx/tree/$(git rev-parse HEAD) ; popd
pushd apps  ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/$(git rev-parse HEAD) ; popd
cd nuttx/tools/ci
./cibuild.sh -c -A -N -R testlist/risc-v-05.dat 

NuttX Source: https://github.com/apache/nuttx/tree/0913fa4b7343686c76affdfa177aed73917963ad
NuttX Apps: https://github.com/apache/nuttx-apps/tree/887729409fb64d4c54b18d247e37029b78d90107
Configuration/Tool: rv-virt/citest
test_open_posix/test_openposix_.py::test_ltp_interfaces_pthread_barrierattr_init_2_1 PASSED                  [ 17%]
test_os/test_os.py::test_ostest PASSED                                                                       [ 99%]
=========================== 990 passed, 11 skipped, 67 deselected in 1849.40s (0:30:49) ============================

@lupyuen
testing/ltp: Increase Stack Size
8877294 
Inside CI Build risc-v-05: `rv-virt:citest` fails with a Stack Overflow at ltp_interfaces_pthread_barrierattr_init_2_1:
- apache/nuttx#15170

This PR doubles the Stack Size for `testing/ltp` (from 4096 bytes to 8192), so that `rv-virt:citest` completes successfully.
@lupyuen lupyuen linked an issue Dec 16, 2024 that may be closed by this pull request
[BUG] rv-virt:citest fails with Load Access Fault at ltp_interfaces_pthread_barrierattr_init_2_1 (risc-v-05) apache/nuttx#15170
Closed
1 task
cederom
cederom approved these changes Dec 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lupyuen nice catch! :-)

@xiaoxiang781216 xiaoxiang781216 merged commit 9c5568c into apache:master Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cederom cederom cederom approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees

No one assigned

Labels

Area: Testing Size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] rv-virt:citest fails with Load Access Fault at ltp_interfaces_pthread_barrierattr_init_2_1 (risc-v-05)

3 participants

@lupyuen @cederom @xiaoxiang781216