Skip to content

App: zig example - Hello#1059

Merged
xiaoxiang781216 merged 1 commit intoapache:masterfrom
kassane:zig_example
Mar 16, 2022
Merged

App: zig example - Hello#1059
xiaoxiang781216 merged 1 commit intoapache:masterfrom
kassane:zig_example

Conversation

@kassane
Copy link
Copy Markdown
Contributor

@kassane kassane commented Mar 13, 2022

Summary

Hello zig.

Impact

none.

Testing

Arch Linux - simulation

Comment thread examples/hello_rust/Makefile Outdated
Comment thread examples/hello_zig/Makefile Outdated
@xiaoxiang781216
Copy link
Copy Markdown
Contributor

@kassane please reorg your patchset too?

@kassane kassane requested a review from xiaoxiang781216 March 15, 2022 16:36
Copy link
Copy Markdown
Contributor

@xiaoxiang781216 xiaoxiang781216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need add new rule for .zig in Makefile, I think.

rename example - fix

confusion-rename fixed

zigflags added

rm zigflag single-threaded

zig rules added
@xiaoxiang781216 xiaoxiang781216 merged commit cdb04f6 into apache:master Mar 16, 2022
@kassane kassane mentioned this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants